DBAAS-972 Grant access to the newly created database instance in Atlas Operator #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
…/namespaces for the same Atlas cluster
…et has been deleted or credentials are expired
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
…or DBaaSConnection
…ssue when no atlas project CR is found
Signed-off-by: Tommy Hughes <[email protected]>
Fix code issues after rebasing on 8/31
…processing connections
…processing connections: add unit test
DBAAS-956 MongoDB Atlas Operator incorrectly sets host to empty when processing connections
… on Thanos loaded on Grafana with status True (RHEcosystemAppEng#62) * DBAAS-906 Operator Metrics - Instance with Pending status on Thanos loaded on Grafana with status True * DBAAS-906 Operator Metrics - Instance with Pending status on Thanos loaded on Grafana with status True: address review comments * DBAAS-906 Operator Metrics - Instance with Pending status on Thanos loaded on Grafana with status True: address review comments
jianrongzhang89
requested review from
jeremyary,
redhatHameed,
tchughesiv and
xieshenzh
tchughesiv
requested changes
Nov 1, 2022
jianrongzhang89
force-pushed
the
access-ip
branch
from
4da02c0 to
f8629f7
Compare
tchughesiv
reviewed
Nov 3, 2022
| // GetPublicIP returns the static outbound public IP of the OpenShift Cluster | ||
| // Or when the operator runs locally, the h | ||
| func GetPublicIP() (string, error) { | ||
| req, err := http.Get("http://ip-api.com/json/") |
There was a problem hiding this comment.
https://ip-api.com/ says "Free for non-commercial use, no API key required"... which is fine as an open source project. Gets tricky when deploying to managed environments or as an official RH product. We need to discuss this a bit more i think.
There was a problem hiding this comment.
@tchughesiv as we discussed earlier, we won't set the default to use the current cluster public IP as the IP may change, or may have multiple IPs (for AWS). Instead, we ask the user to provide the IP. In addition, the code is updated to make sure that when a new db instance is created for an existing Atlas Project, the project's IP access list remains the same in Atlas. The unit test has also been updated accordingly.
tchughesiv
force-pushed
the
dbaas-refactor-rebased
branch
from
cc41886 to
3903485
Compare
tchughesiv
force-pushed
the
dbaas-refactor-rebased
branch
2 times, most recently
from
52df71c to
ce506a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, after a MongoDB instance is created with a new Atlas Project, the user has to go to the Atlas Portal to add the ip address to the ip access-list before an application can connect to the newly created db instance.
This enhancement is for the Atlas Operator to automatically grant access to the newly created database instance so that the above manual step can be avoided.
Tested successfully in a local devt cluster.