Skip to content

Conversation

@bandrivskiy
Copy link
Contributor

Notes

This PR adds a C-compatible FFI function, rgblib_sign_psbt, which exposes the internal sign_psbt logic
The new binding allowsrgb-lib-nodejs to invoke PSBT signing func via FFI

@bandrivskiy bandrivskiy force-pushed the c-ffi-sign branch 3 times, most recently from 092c7d6 to 9cfd2d0 Compare May 30, 2025 13:50
Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please put the method in alphabetical order and address the small requested change

@zoedberg
Copy link
Member

zoedberg commented Jun 5, 2025

Thanks for addressing the requested changes! Could you please squash the changes in a single commit called c-ffi bindings: add sign_psbt?

@codecov
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (6691268) to head (67c488b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files          60       60           
  Lines       20271    20271           
=======================================
  Hits        19571    19571           
  Misses        700      700           
Flag Coverage Δ
rust 96.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zoedberg
Copy link
Member

zoedberg commented Jun 8, 2025

LGTM! Thank you!

@zoedberg zoedberg merged commit 1d41cfb into RGB-Tools:master Jun 8, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants