Enhance core tests and Initialization of ADR - #2
Merged
Conversation
- Add 3 architecture decision records under dev/adr/:
- 0001: ecosystem-wide agent config via symlink to rstsr-agents.
- 0002: all tests on all devices via per-(order, device) entry binaries.
- 0003: three-artifact NumPy-faithfulness model (parity test / coverage
checklist / differences report).
- EN source in dev/adr/ + zh-hans mirror under i18n; grouped via
_category_.json (label "ADRs" / "架构决策 (ADRs)").
- Marked ai_generated: true (EN) / translated (zh-hans); build passes clean.
Co-authored-by: Claude Code <noreply@anthropic.com>
Co-authored-by: glm-5.2 <service@zhipuai.cn>
ADR-0002 stated "Only DeviceCpuSerial and DeviceFaer are wired now", but the rstsr repo only contains entry_row_cpu.rs. Correct to: only DeviceCpuSerial (row-major, entry_row_cpu.rs) is wired today; entry_row_faer.rs and entry_col_cpu.rs are planned but not yet present. Fixed in both the English source (dev/adr/) and the zh-hans translation. Contents generated by AI (model glm-5.2). Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: glm-5.2 <service@zhipuai.cn>
- ADR-0000: charter - an ADR records a decision and its rationale (not a changelog or backlog); Context/Decision/Considered/Consequences structure; consequences are implications not a work log, no Follow-up/TODO, one decision per ADR. - ADR-0004: parity tests for `creation_from_tensor.rs` functions live in a dedicated `creation_from_tensor/` category mirroring the source module; broadens the ADR-0003 tracking scope to manipulation + creation_from_tensor; unimplemented functions recorded as `todo` rows. - ADR-0003: status set gains `todo`; differences report splits into open (`numpy_differences.md`) and resolved (`numpy_differences_resolved.md`). - ADR-0001: drop the hardcoded `/scratch/rstsr_pack/...` path; keep the symlink description general. Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: glm-5.2 <service@zhipuai.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR (Architecture decision record)