Issue 2110 multisig quorum tests

[boalambo]

📝 Description

Adds test coverage for the over quorum boundary case in the multisig-signature helper (verify_op). This completes the test coverage for all quorum boundary cases as specified in issue #2110.

🎯 Type of Change

• Other (test coverage improvement)

🔧 Changes Made

Files Modified

• quicklendx-contracts/src/test_multisig.rs

New Files Added

• None

Key Changes

• Added test_verify_op_over_quorum test function (lines 235-283)
• Test verifies that verify_op succeeds when more signatures than the threshold are provided (3 signatures with threshold 2)
• Completes coverage for all three quorum boundary cases: below quorum, at quorum, and over quorum

🧪 Testing

• Test follows existing patterns in the file
• Test is deterministic (no random values)
• Test uses assertive naming convention
• Unit tests pass (blocked by pre-existing compilation errors in lib.rs)
• Integration tests pass (blocked by pre-existing compilation errors in lib.rs)
• No breaking changes introduced

Test Coverage

The multisig-signature helper now has complete quorum boundary coverage:

• Below quorum: test_verify_op_insufficient_signatures - 0 signatures when threshold is 1 (fails with NotEnoughSignatures)
• At quorum: test_verify_op_success - 2 signatures when threshold is 2 (succeeds)
• Over quorum: test_verify_op_over_quorum - 3 signatures when threshold is 2 (succeeds) ✅ NEW

📋 Contract-Specific Checks

• Test uses Soroban SDK primitives correctly
• Soroban contract builds successfully (blocked by pre-existing compilation errors)
• WASM compilation works (blocked by pre-existing compilation errors)
• Test follows #![no_std] discipline (no std calls)
• Test uses proper error handling patterns

Contract Testing Details

Test uses the same pattern as existing multisig tests:

• Generates Ed25519 keypairs for 3 owners
• Initializes multisig with threshold = 2
• Has all 3 owners sign the same message
• Verifies that verify_op succeeds despite having more signatures than required

📋 Review Checklist

• Code follows project style guidelines
• Test naming is assertive (not interrogative)
• No sensitive data exposed
• Test is deterministic
• Code is self-documenting
• No hardcoded secrets

🔍 Code Quality

• Clippy warnings addressed (blocked by pre-existing compilation errors)
• Code formatting follows rustfmt standards
• No unused imports or variables
• Test function is properly documented through comments
• Logic is clear and commented

🚀 Performance & Security

• No security vulnerabilities introduced (test code only)
• Input validation follows existing patterns
• No sensitive information in logs

📚 Documentation

• Code comments explain the test scenario
• Test name describes the expected behavior

🔗 Related Issues

Closes #2110

📋 Additional Notes

Important: Cannot run cargo test or cargo clippy due to 96 pre-existing compilation errors in lib.rs that are completely unrelated to the multisig module. These errors include:

• Missing BatchSizeExceeded variant in QuickLendXError
• Missing arguments in Invoice::new and set_protocol_limits calls
• Various other compilation errors in lib.rs

None of these errors reference multisig.rs or test_multisig.rs, confirming this change is not the cause. The test syntax is correct and follows the exact same pattern as existing tests in the file. Once the pre-existing errors are resolved, CI should pass.

🧪 How to Test

Once pre-existing compilation errors are fixed:

1. Run the specific test: cargo test -p quicklendx-contracts test_verify_op_over_quorum
2. Run all multisig tests: cargo test -p quicklendx-contracts test_multisig
3. Verify WASM build: cargo build --target wasm32-unknown-unknown --release -p quicklendx-contracts
4. Run clippy: cargo clippy --workspace --all-targets -- -D warnings

📸 Screenshots (if applicable)

Not applicable (test code change)

⚠️ Breaking Changes

None

🔄 Migration Steps (if applicable)

None

[drips-wave]

@boalambo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits