Fix qpm qmod zip command file naming and validation#61
Open
DanTheMan827 wants to merge 1 commit intoQuestPackageManager:mainfrom
Open
Fix qpm qmod zip command file naming and validation#61DanTheMan827 wants to merge 1 commit intoQuestPackageManager:mainfrom
qpm qmod zip command file naming and validation#61DanTheMan827 wants to merge 1 commit intoQuestPackageManager:mainfrom
Conversation
This fixes an issue where the file names in the resulting qmod are those of the resolved file path instead of the intended name. - Check for missing files and panics if any are missing - Check if any of the qmod paths are directories and panics if any are - Use original file name for qmod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
qpm qmod zipcommand to use the original file names in the resulting qmod and add checks for missing files and directories, ensuring proper error handling.