Svg exporting #232
Merged
Svg exporting #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
📈Increment the minor version reset the patch |
… svg code display none on path names; move exporting to module use saveSvgasPng font renaming api remap Khula regular as well as light
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all of our SVG export code and offloads it to
saveSvgAsPng. There is an issue with opening custom fonts in older versions of Illustrator, but I have an open PR in the project that handles it. For now this just uses my fork, but we can update it once the PR is finalized.This also fixes the flash-of-wrong-font issue, so I have removed that from index.js
SVG download tested in FF, Chrome, Safari