fix: Fix max_exclusive=0 being ignored#158
Merged
Andreas Albert (AndreasAlbertQC) merged 3 commits intoOct 6, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 2896 2896
=========================================
Hits 2896 2896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Andreas Albert (AndreasAlbertQC)
requested review from
Oliver Borchert (borchero) and
Daniel Elsner (delsner)
as code owners
This reverts commit defe64b.
Oliver Borchert (borchero)
approved these changes
Oct 6, 2025
Oliver Borchert (borchero)
left a comment
Oliver Borchert (borchero)
left a comment
Member
There was a problem hiding this comment.
Whoops, thank you!
Andreas Albert (AndreasAlbertQC)
deleted the
2025-10-06_fix-max-exclusive
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We do not properly differentiate between
max_exclusive=Noneandmax_exclusive=0because we naively cast to bool.Changes