Align US strategy lifecycle gates#205
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58d2f00115
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| available_inputs=frozenset(base_adapter.available_inputs or definition.required_inputs), | ||
| portfolio_input_name=base_adapter.portfolio_input_name | ||
| or ("portfolio_snapshot" if "portfolio_snapshot" in definition.required_inputs else None), |
There was a problem hiding this comment.
For the shadow combo profiles on Schwab, Longbridge, and Firstrade, this new adapter path skips the cross-target-mode normalization done in _build_runtime_adapter_for_platform: these profiles emit weight targets while those platforms are value-native, so their adapters used to add portfolio_snapshot and set portfolio_input_name for translation. Because the profiles are still exposed through PLATFORM_RUNTIME_ADAPTERS, get_platform_runtime_adapter("us_equity_combo", platform_id="schwab") now returns an adapter with only russell_snapshot/current_holdings, leaving value-mode runtimes without the portfolio snapshot needed to convert weights into dollar targets.
Useful? React with 👍 / 👎.
| benchmark="SPY", | ||
| role="us_equity_combo", | ||
| status="runtime_enabled", | ||
| status="shadow_candidate", |
There was a problem hiding this comment.
In contexts that load us_equity_combo_entrypoint directly, this catalog demotion is not reflected because the entrypoint is still constructed from combo_manifests.us_equity_combo_manifest, whose description continues to label the profile as live and whose default config has no shadow marker. A manifest-driven platform or operator UI can therefore still surface us_equity_combo as live even though get_runtime_enabled_profiles() now excludes it; please update the combo manifest alongside this status change.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
PYTHONPATH=src:/Users/lisiyi/Projects/QuantPlatformKit/src python3 -m pytest -q tests/test_catalog.py tests/test_contract_governance.pygit diff --check origin/main...HEAD