Skip to content

Avoid fake secret literal in gate test#163

Merged
Pigbibi merged 1 commit into
mainfrom
codex/fake-secret-test-sentinel
Jul 6, 2026
Merged

Avoid fake secret literal in gate test#163
Pigbibi merged 1 commit into
mainfrom
codex/fake-secret-test-sentinel

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • build the fake OpenAI-style key at runtime in the gate test
  • keep the hardcoded-secret detection coverage while avoiding static secret-scanner false positives

Tests

  • python3 -m pytest tests/test_gate_codex_app_review.py -q
  • inline regex check: no sk-[A-Za-z0-9]{20,} literal remains in tests/test_gate_codex_app_review.py
  • git diff --check

Note: full python3 -m pytest -q still hits existing collection errors for missing generated/modules unrelated to this one-line test change; the repository CI currently runs pytest with || true.

Co-Authored-By: Codex <noreply@openai.com>
@cursor

cursor Bot commented Jul 5, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi Pigbibi merged commit 677127e into main Jul 6, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/fake-secret-test-sentinel branch July 6, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant