Complete shadow signal notification workflow#3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ee7f4e8c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| schedule: | ||
| # Weekly after Friday US market close. This remains shadow-only and does not | ||
| # place trades. | ||
| - cron: "30 2 * * 6" |
There was a problem hiding this comment.
Use the Friday market date for scheduled issues
Because this cron fires at 02:30 UTC on Saturday, the new issue step later falls back to dt.date.today() and titles the request with Saturday's date. For the weekly post-Friday-close run, that asks the bridge for an as_of/signal_history date that is one day after the Friday market session, which can misdate the shadow artifact and break point-in-time replay assumptions. Pass the intended market date into post_shadow_signal_request.py or derive it explicitly instead of using the runner's UTC date.
Useful? React with 👍 / 👎.
Summary
Validation