-
Notifications
You must be signed in to change notification settings - Fork 0
[codex] document runtime target desired state #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,6 +77,24 @@ | |
| "type": "string", | ||
| "enum": ["live", "paper", "dry_run"] | ||
| }, | ||
| "scheduler": { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "timezone": { | ||
| "type": "string" | ||
| }, | ||
| "main_time": { | ||
| "type": "string" | ||
| }, | ||
| "probe_time": { | ||
| "type": "string" | ||
| }, | ||
| "precheck_time": { | ||
| "type": "string" | ||
| } | ||
|
Comment on lines
+87
to
+95
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For schema-only validation paths, these new scheduler time fields accept any string, so values such as Useful? React with 👍 / 👎. |
||
| } | ||
| }, | ||
| "execution_windows": { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a target is validated only through
schemas/runtime-target.schema.json, a presentruntime_target.schedulercan omittimezone,main_time,probe_time, orprecheck_timeand still pass because this new object has norequiredlist. The Python validator rejects the same payload (validate_runtime_targetrequires a non-empty timezone and all three time fields), so schema-based consumers can accept targets that later failruntime_settings.py validateor platform parsing; add the scheduler fields torequiredto keep the shared schema consistent with the runtime contract.Useful? React with 👍 / 👎.