Skip to content

chore: pin hard-failure drift review bridge #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 11, 2026
Merged

chore: pin hard-failure drift review bridge #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable-drift-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ jobs:
uses: actions/checkout@v6
with:
repository: QuantStrategyLab/AIAuditBridge
ref: cd35a96c4c56ba75034f7bbe3cf803e7dad3c283
ref: 66b1107f7cb081ab1409e8b6ebdc6334999fa5dc

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin a bridge build that trusts this workflow SHA

When strategy repos rotate their reusable drift caller to this new QPK revision, the Codex primary review will be rejected by the audit service before any dual review can run: I checked the pinned AIAuditBridge revision 66b1107..., and its service deployment allowlist still only includes QuantPlatformKit/.github/workflows/reusable-drift-check.yml@644cd900... and @d0a081ca..., not this workflow revision. Because run_codex_service_review authenticates with the GitHub OIDC token and the service validates job_workflow_ref, critical-drift runs with CODEX_AUDIT_SERVICE_URL configured will fail with an auth error instead of producing the durable review/issue path this workflow expects.

Useful? React with 👍 / 👎.

path: external/AIAuditBridge

- name: Dual-review critical drift
Expand Down
2 changes: 1 addition & 1 deletion tests/test_reusable_drift_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_reusable_drift_workflow_enforces_lifecycle_preflight() -> None:
assert "create_issues_for_domain" in workflow
assert 'CODEX_AUDIT_SERVICE_URL: ${{ secrets.codex_audit_service_url }}' in workflow
assert 'AI_GATEWAY_SERVICE_URL: ${{ inputs.ai_gateway_service_url }}' in workflow
assert 'ref: cd35a96c4c56ba75034f7bbe3cf803e7dad3c283' in workflow
assert 'ref: 66b1107f7cb081ab1409e8b6ebdc6334999fa5dc' in workflow
assert workflow.count('GH_TOKEN: ${{ github.token }}') >= 2
assert 'if [ "$review_rc" -eq 3 ]; then' in workflow
assert 'item.get("dispatch", {}).get("github_issue")' in workflow
Expand Down
Loading