Skip to content

refactor(cloud): complete AWS fetch_id_token, document URI schemes, update README#120

Merged
Pigbibi merged 3 commits into
mainfrom
refactor/cloud-polish
Jun 28, 2026
Merged

refactor(cloud): complete AWS fetch_id_token, document URI schemes, update README#120
Pigbibi merged 3 commits into
mainfrom
refactor/cloud-polish

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

补完上次 cloud decoupling review 中发现的 3 个遗漏项:

1. AwsDeploymentContext.fetch_id_token 实现

  • EC2 IMDSv2 / ECS metadata v4 自动检测,返回实例身份文档
  • 本地开发 fallback 到 STS GetCallerIdentity
  • 明确文档说明:AWS 无 GCP audience-based ID token 的等价物

2. Env provider 设计说明

  • env_provider.py 中添加完整 docstring,解释 ObjectStore/DocumentStore 复用 local 实现的原因
  • 不是遗漏,而是"零依赖 CI provider"的刻意设计

3. URI scheme 文档

  • ports.py ObjectStore Protocol 添加完整 URI scheme 映射表
  • 明确各 provider 支持 scheme 及跨 provider 约束
  • README / README.zh-CN 更新,补充 AWS provider

Testing

  • 366 passed, 1 skipped

Breaking Changes

None.

…pdate README

- AwsDeploymentContext.fetch_id_token: implement EC2/ECS identity resolution
  with STS fallback for local dev. Added clear docs that AWS has no native
  equivalent to GCP audience-based ID tokens.
- env_provider: document design rationale for reusing local ObjectStore/
  DocumentStore (not a gap — by design for zero-dependency CI support)
- ports.py: document URI scheme → provider mapping, cross-provider constraints
- README / README.zh-CN: add AWS provider to supported list

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🤖 Codex PR Review

⚠️ Review skipped: The Codex review could not be completed.

No Codex service URL or API key configured. Set CODEX_AUDIT_SERVICE_URL, ANTHROPIC_API_KEY, or OPENAI_API_KEY.

Please ensure a human reviewer checks this PR before merging.

@Pigbibi Pigbibi merged commit 98794ae into main Jun 28, 2026
1 of 2 checks passed
@Pigbibi Pigbibi deleted the refactor/cloud-polish branch June 28, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant