refactor(cloud): decouple GCP-specific naming, add cloud-neutral API and AWS provider#119
Merged
Conversation
…and AWS provider Phase 1 — Internal naming unification: - Rename gcp_project_id → project_id, gcs_prefix_uri → cloud_prefix_uri - Rename gcs_uri → cloud_uri, _gcs_* → _cloud_*, _parse_gcs_uri → _parse_cloud_uri - All public APIs keep backward-compat aliases with DeprecationWarning - Env vars: new CLOUD_* names with fallback to old GCS_* names - URI parsers now accept both gs:// and s3:// Phase 2 — AWS provider: - Add aws_provider.py implementing all 6 Protocol types - SecretStore → AWS Secrets Manager, ObjectStore → S3 - DocumentStore → DynamoDB, ComputeDiscovery → EC2 - Register aws in all factory functions (QSL_CLOUD_PROVIDER=aws) Phase 3 — Downstream repos: - BinancePlatform: remove hardcoded google.cloud.firestore import - CryptoLivePoolPipelines: rename gcp_project_id/gcs_bucket/gcs_root_prefix - All platform repos: update kwarg names to cloud-neutral variants Tests: 366 passed, 0 failed, +7 new AWS provider registration tests. Co-Authored-By: Claude <noreply@anthropic.com>
Implement AwsSecretStore, AwsObjectStore (S3), AwsDocumentStore (DynamoDB), AwsComputeDiscovery (EC2), AwsDeploymentContext. Activate via QSL_CLOUD_PROVIDER=aws. Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Codex PR ReviewPlease ensure a human reviewer checks this PR before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three-phase cleanup to fully decouple cloud provider dependencies from QuantPlatformKit, making it truly provider-agnostic.
Phase 1 — Internal naming unification
Phase 2 — AWS provider
Phase 3 — Downstream repos
Testing
Breaking Changes
None. All old names kept as deprecated aliases with warnings.