Skip to content

Add small-account allocation drift notes#108

Merged
Pigbibi merged 1 commit into
mainfrom
codex/small-account-drift-notes
Jun 24, 2026
Merged

Add small-account allocation drift notes#108
Pigbibi merged 1 commit into
mainfrom
codex/small-account-drift-notes

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add shared helpers to estimate projected small-account allocation drift after whole-share orders
  • add formatter for localized drift notifications
  • cover submitted-order, large-account skip, non-target symbol filtering, and i18n formatting cases

Tests

  • PYTHONPATH=/home/ubuntu/Projects/QuantPlatformKit/src timeout 120 python -m unittest tests.test_small_account_compatibility

@Pigbibi Pigbibi merged commit b821e8c into main Jun 24, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/small-account-drift-notes branch June 24, 2026 06:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3175ec240

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +156 to +157
if not isinstance(raw_order, Mapping):
continue

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle ExecutionReport submitted orders

When callers pass the ExecutionReport objects produced by this package's broker adapters (src/quant_platform_kit/common/models.py:70-79), they are not Mappings, so this guard drops every submitted order. In that case a submitted one-share buy is still projected as value 0 and the drift notification reports the wrong allocation; accept attribute-based reports here or normalize them before this check.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant