Add small-account allocation drift notes#108
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3175ec240
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if not isinstance(raw_order, Mapping): | ||
| continue |
There was a problem hiding this comment.
Handle ExecutionReport submitted orders
When callers pass the ExecutionReport objects produced by this package's broker adapters (src/quant_platform_kit/common/models.py:70-79), they are not Mappings, so this guard drops every submitted order. In that case a submitted one-share buy is still projected as value 0 and the drift notification reports the wrong allocation; accept attribute-based reports here or normalize them before this check.
Useful? React with 👍 / 👎.
Summary
Tests