Skip to content

chore(deps): align QPK pin to 31892425a022 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 10, 2026
Merged

chore(deps): align QPK pin to 31892425a022 #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies = [
"google-cloud-storage",
"google-auth",
"longport==3.0.23",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@56a03364d517fd0e2efb2c4d4add8a785fc5e857",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@31892425a02242126265ac07a626d98796daa459",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use the QPK_PIN value for the dependency pin

In the CI path I checked (.github/workflows/ci.yml lines 87-92), the pin guard runs against external/QuantPlatformKit/QPK_PIN and compares QuantPlatformKit.git@... entries to that file's contents, not to the checked-out repository commit. At the referenced 31892425... commit, QPK_PIN contains 618b786d27351dc9ec186f27d01f7da39c6dcf81, so this pyproject.toml entry will be rejected by the mandatory pin-consistency check before CI can complete; pin to the QPK_PIN value and refresh the lockfile instead.

Useful? React with 👍 / 👎.

"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@17ddb86c72d44b2c7b78ba7a10d8f71b21180166",
"hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@b6a8ac2ad3c8110b5ea74fb059c8206388d63bcd",
]
Expand Down Expand Up @@ -61,5 +61,5 @@ include = [

[tool.uv]
override-dependencies = [
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@56a03364d517fd0e2efb2c4d4add8a785fc5e857",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@31892425a02242126265ac07a626d98796daa459",
]
2 changes: 1 addition & 1 deletion qsl.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ upgrade_ring = "ring_d"
allow_legacy = false

[qsl.requires]
quant_platform_kit = "56a03364d517fd0e2efb2c4d4add8a785fc5e857"
quant_platform_kit = "31892425a02242126265ac07a626d98796daa459"
us_equity_strategies = "17ddb86c72d44b2c7b78ba7a10d8f71b21180166"
hk_equity_strategies = "b6a8ac2ad3c8110b5ea74fb059c8206388d63bcd"

Expand Down
6 changes: 3 additions & 3 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading