Skip to content

chore(deps): align QPK pin to 2381aa4577e9#319

Merged
Pigbibi merged 3 commits into
mainfrom
auto/qpk-pin-sync-2381aa4577e9
Jul 10, 2026
Merged

chore(deps): align QPK pin to 2381aa4577e9#319
Pigbibi merged 3 commits into
mainfrom
auto/qpk-pin-sync-2381aa4577e9

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • 自动将 QPK pin 对齐到 2381aa4577e9
  • 若仓库使用 uv.lock,同步刷新 lockfile

Test plan

  • Repo CI 转绿

🤖 Generated with Claude Code

Automated downstream QPK pin update after QPK_PIN landed on main.

Co-Authored-By: Claude <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2894077cd5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread uv.lock Outdated
Co-Authored-By: Codex <noreply@openai.com>
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

Merge allowed: 1 finding(s) reported but none are blocking

ℹ️ Other Findings

1. 🟡 [MEDIUM] Reliability in tests/test_qsl_metadata.py

The new assertion assumes uv.lock will always contain QuantPlatformKit.git?rev=<pin>#<pin>, but this repository's previous uv.lock entry already disproves that invariant: the requested rev was 69a025... while the recorded source fragment was #53b2ca.... uv does not guarantee that the post-# fragment exactly matches the requested rev string, so future valid lockfile regenerations can fail this test even when qsl.toml, pyproject.toml, and uv.lock are correctly aligned. (line 28)

Suggestion: Relax the check to assert only the stable part of the lock entry, such as the presence of QuantPlatformKit.git?rev=<pin>, or parse uv.lock structurally and compare the rev= value instead of requiring the trailing fragment to equal the pin.


Review by Codex PR Review bot • PR

@Pigbibi Pigbibi merged commit 263f9ca into main Jul 10, 2026
3 checks passed
@Pigbibi Pigbibi deleted the auto/qpk-pin-sync-2381aa4577e9 branch July 10, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant