Skip to content

fix(ops): support clean targeted Gateway rebuilds#98

Merged
Pigbibi merged 3 commits into
mainfrom
codex/diagnose-workspace-source-20260713
Jul 12, 2026
Merged

fix(ops): support clean targeted Gateway rebuilds#98
Pigbibi merged 3 commits into
mainfrom
codex/diagnose-workspace-source-20260713

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add read-only diagnostics for the remote source run.sh alongside the built image copy
  • add an opt-in rebuild_without_cache input for full manual deploys
  • keep normal push/scheduled/manual build behavior unchanged unless explicitly selected

Evidence

  • U***8560 remote source is 6764 bytes with the expected hash, while the cached image layer contains a zero-byte run.sh
  • the prior targeted full rebuild reused the bad COPY layer (#8 CACHED)

Validation

  • bash tests/test_install_2fa_bot_watcher.sh
  • bash tests/test_wait_for_ib_gateway_ready.sh
  • bash tests/test_workflow_shared_config.sh
  • bash tests/test_docker_compose_ports.sh
  • bash tests/test_gateway_recovery_scripts.sh
  • bash tests/test_run_override_api_config.sh
  • actionlint .github/workflows/*.yml
  • git diff --check

Pigbibi and others added 2 commits July 13, 2026 06:11
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi enabled auto-merge (squash) July 12, 2026 22:14
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

Merge allowed: blocking findings were cleared by independent Codex arbitration

⚖️ Codex Review Arbitration

clear: The prior high-severity logic bug in .github/workflows/main.yml is demonstrably fixed in the current cumulative diff. The deploy job now exports WORKFLOW_DISPATCH_REBUILD_WITHOUT_CACHE: ${{ github.event.inputs.rebuild_without_cache }} and the rebuild branch tests the expanded shell variable as if [ "${WORKFLOW_DISPATCH_REBUILD_WITHOUT_CACHE:-false}" = 'true' ]; then, which allows parameter expansion and correctly selects sudo docker compose build --no-cache "${compose_service_name}" when the manual input is true. This directly addresses the prior failure mode where single-quoting the expansion prevented any effect. The updated shell test in tests/test_workflow_shared_config.sh also asserts the corrected condition and no-cache build command, with no conflicting source-of-truth evidence in the provided diff.


Review by Codex PR Review bot • PR

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi merged commit e001c6d into main Jul 12, 2026
3 checks passed
@Pigbibi Pigbibi deleted the codex/diagnose-workspace-source-20260713 branch July 12, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant