Harden IBKR gateway login readiness#84
Conversation
Co-Authored-By: Codex <noreply@openai.com>
🤖 Codex PR ReviewPlease ensure a human reviewer checks this PR before merging. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28c1653d50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local accept_incoming="${TWS_ACCEPT_INCOMING:-}" | ||
|
|
||
| if [ "${IB_GATEWAY_SKIP_IBC_READ_ONLY_API_CONFIG:-yes}" = "yes" ] && [ "${read_only_api,,}" = "no" ]; then | ||
| set_ibc_config_value "ReadOnlyApi" "" |
There was a problem hiding this comment.
When READ_ONLY_API is left at the compose default no, this default skip=yes branch rewrites IBC's ReadOnlyApi back to blank, so fresh/recreated Gateway settings no longer clear the Read-Only API checkbox. In this repo the compose file does not mount a persistent TWS settings volume, and full deploys recreate the container, so the rollout can pass because the readiness probe connects with readonly=True while downstream order placement remains blocked until someone fixes the UI setting manually.
Useful? React with 👍 / 👎.
1 participant
Summary
Test Plan
Live validation