codex: monthly audit fixes for issue #38

[quantcrossrepoautomation]

Triggered by monthly review issue #38: #38

Changed Files

• src/hk_equity_snapshot_pipelines/monthly_snapshot_audit_issue.py
• tests/test_monthly_snapshot_audit_issue.py

Codex Result

Verdict

Blocked. I fixed a low-risk monthly-report defect, but issue #38 still lacks the evidence required for HK snapshot promotion, and the generated staging input path remains unsafe as production-source evidence.

Findings

• High: src/hk_equity_snapshot_pipelines/low_vol_dividend_longbridge_snapshot.py and src/hk_equity_snapshot_pipelines/low_vol_dividend_public_snapshot.py derive non-price fields such as market_cap_hkd, payout_ratio, earnings_positive, pe_ratio, and free_cash_flow_yield from provider valuation lookups that do not accept an as_of timestamp. For backdated runs this creates look-ahead risk, so public_yfinance_staging / longbridge_openapi_staging should not be treated as point-in-time production-source audit evidence without human follow-up.
• Medium: src/hk_equity_snapshot_pipelines/monthly_snapshot_audit_issue.py only emitted a longbridge readiness command even though the monthly gate explicitly requires evidence for both longbridge and ibkr. That could lead operators to run an incomplete monthly checklist. Fixed.

Changes Made

• Updated src/hk_equity_snapshot_pipelines/monthly_snapshot_audit_issue.py so the generated monthly issue now prints reproducible print_snapshot_readiness.py commands for both longbridge and ibkr.
• Added tests/test_monthly_snapshot_audit_issue.py to lock the dual-platform readiness commands into the monthly issue payload.

Verification

• Added focused regression coverage for the monthly issue payload.
• Repository-local command execution could not be run in this sandbox because every shell attempt failed with bwrap: loopback: Failed RTM_NEWADDR: Operation not permitted.

Residual Risk

• Issue HK Snapshot Monthly Audit: 2026-07 #38 still provides no point-in-time production-source audit, no 3-fold OOS backtest pack, no dual-broker dry-run evidence, no bilingual notification delivery-log evidence, and no operator approval pack; promotion must remain blocked.
• The staging snapshot generators still need a human decision: either downgrade them to research-only evidence or add audited point-in-time fundamentals plus availability-date lineage before operators use them for monthly promotion evidence.