Skip to content

feat(telemetry): persist total_equity for live return series #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 2 commits into from
Jul 9, 2026
+2 −0
Merged

feat(telemetry): persist total_equity for live return series #214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3601b27
feat(telemetry): include total_equity in PerformanceMonitor records
Pigbibi Jul 9, 2026
154b0d3
chore(ci): retrigger gate after cancelled run
Pigbibi Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions application/rebalance_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,8 @@ def log_message(message: str) -> None:
"submitted_orders": result.get("submitted_orders"),
"skipped_orders": result.get("skipped_orders"),
"error": result.get("error"),
"total_equity": (result.get("portfolio") or {}).get("total_equity")
or (result.get("portfolio") or {}).get("equity"),
Comment on lines +744 to +745

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve zero-valued total_equity in telemetry

When the portfolio's total_equity is exactly 0.0 (for example the existing zero-equity strategy-cycle path), this or treats it as absent and falls back to portfolio.get("equity"), which is normally unset, so the execution telemetry records None instead of the real zero. That defeats the new live return series field for empty/small accounts and can make the collector drop or misinterpret a valid datapoint; check key presence or is not None instead of truthiness.

Useful? React with 👍 / 👎.

},
)
return result
Loading