fix: persist lifecycle backtests for drift checks by Pigbibi · Pull Request #82 · QuantStrategyLab/CryptoStrategies

Pigbibi · 2026-07-10T16:32:38Z

Summary

switch drift-check to QuantPlatformKit reusable drift workflow
require lifecycle snapshot + backtest preflight before drift
persist walk-forward baseline backtests into lifecycle store

Validation

PYTHONPATH=/Users/lisiyi/Projects/_worktrees/quant_p0/QuantPlatformKit/src python3 -m pytest -q tests/test_drift_workflow_config.py tests/test_run_walk_forward_backtest.py

Dependency

merge after QuantStrategyLab/QuantPlatformKit reusable drift workflow lands on main

github-actions · 2026-07-10T16:34:02Z

🤖 Codex PR Review

⚠️ Review unavailable: Codex review quota or capacity is unavailable. No direct paid API fallback was used; required CI checks remain the merge gate.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac3eece2fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f15ef912af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61f6aa77ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2089407f2c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 062d0f956c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Codex <noreply@openai.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10ed16a324

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Codex <noreply@openai.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cddce269e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi · 2026-07-11T00:51:11Z

Review findings reconciled: the reusable QPK workflow restores the uploaded lifecycle store into the downstream job, so no cloud promotion/client is required; producer checkout is pinned to the artifact run SHA; baselines use QPK metrics from historical walk-forward folds while monitored returns are generated separately through the latest real input date.

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread scripts/run_walk_forward_backtest.py Outdated

Comment thread tests/test_run_walk_forward_backtest.py Outdated

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread .github/workflows/drift-check.yml

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread scripts/run_walk_forward_backtest.py

Pigbibi enabled auto-merge July 10, 2026 17:41

Pigbibi force-pushed the codex/quant-p0-20260710 branch from 9fb4afb to 0c3a2d6 Compare July 10, 2026 17:43

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread .github/workflows/drift-check.yml

Pigbibi force-pushed the codex/quant-p0-20260710 branch 2 times, most recently from bbcdcca to 6904c8e Compare July 10, 2026 18:02

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread scripts/run_walk_forward_backtest.py

Comment thread scripts/run_walk_forward_backtest.py

fix(ci): align drift baseline store and workflow pin

4044ec7

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi force-pushed the codex/quant-p0-20260710 branch from 062d0f9 to 4044ec7 Compare July 10, 2026 18:53

Pigbibi and others added 2 commits July 11, 2026 03:02

fix(ci): persist validated lifecycle baselines

9a700c8

Co-Authored-By: Codex <noreply@openai.com>

fix(ci): seed lifecycle backtests before drift checks

10ed16a

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi force-pushed the codex/quant-p0-20260710 branch from 10ed16a to 7959470 Compare July 10, 2026 19:17

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread .github/workflows/drift-check.yml

fix(ci): share drift preflight through lifecycle bucket

1be0b37

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi force-pushed the codex/quant-p0-20260710 branch from 7713ed1 to 1be0b37 Compare July 10, 2026 19:41

fix(ci): harden lifecycle preflight persistence

9137f80

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi force-pushed the codex/quant-p0-20260710 branch from 2764b28 to 9137f80 Compare July 10, 2026 20:01

Pigbibi and others added 5 commits July 11, 2026 04:03

chore(ci): pin caller lifecycle drift workflow

d880395

Co-Authored-By: Codex <noreply@openai.com>

fix(ci): isolate drift baseline promotion

ae52498

Co-Authored-By: Codex <noreply@openai.com>

fix: isolate crypto walk-forward lifecycle records

57baad8

Co-Authored-By: Codex <noreply@openai.com>

fix(ci): remove OIDC from preflight job

da3de79

Co-Authored-By: Codex <noreply@openai.com>

fix(ci): gate drift on successful preflight

cddce26

Co-Authored-By: Codex <noreply@openai.com>

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread .github/workflows/drift-check.yml Outdated

Comment thread .github/workflows/drift-check.yml

Comment thread .github/workflows/drift-check.yml Outdated

Pigbibi and others added 4 commits July 11, 2026 07:49

fix: run crypto drift preflight on trusted inputs

7135cf5

Co-Authored-By: Codex <noreply@openai.com>

fix: derive crypto baseline from exact return tail

ec91e85

Co-Authored-By: Codex <noreply@openai.com>

fix: fail closed on crypto input corruption

6570847

Co-Authored-By: Codex <noreply@openai.com>

chore: align QPK compatibility metadata

b3e81a7

Co-Authored-By: Codex <noreply@openai.com>

fix: derive crypto drift baseline from walk-forward returns

6887174

Co-Authored-By: Codex <noreply@openai.com>

This comment has been minimized.

Sign in to view

fix: separate current drift returns from baseline window

80a3524

Co-Authored-By: Codex <noreply@openai.com>

This comment has been minimized.

Sign in to view

Pigbibi merged commit 8e0140d into main Jul 11, 2026
4 checks passed

Pigbibi deleted the codex/quant-p0-20260710 branch July 11, 2026 00:51

Uh oh!

Conversation

Pigbibi commented Jul 10, 2026

Summary

Validation

Dependency

Uh oh!

github-actions Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Codex PR Review

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Pigbibi commented Jul 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Jul 10, 2026 •

edited

Loading