chore(deps): align QPK pin to 8378e93 and add CI gate#71
Conversation
Bump quant-platform-kit git pin to QPK_PIN, refresh uv.lock, and fail CI when pyproject/lockfile pins drift. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 002abf4958
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| requires-python = ">=3.11" | ||
| dependencies = [ | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0af622ac9d47f7ef93f9379f9ded314c27a344ff", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@8378e939d9324ea63a0f45c9f21ba0e2eeb1cfff", |
There was a problem hiding this comment.
Changing this dependency to 8378e939... makes the existing governance test fail: tests/test_contract_governance.py still defines QPK_HEALTH_COMMIT as 0af622ac... and test_qpk_dependency_includes_shared_health_module_release asserts that pyproject.toml matches that exact value. Since .github/workflows/ci.yml still runs python -m pytest -q tests, CI will fail on every run with this new pin until the test expectation is updated as part of the same change.
Useful? React with 👍 / 👎.
| python external/QuantPlatformKit/scripts/check_qpk_pin_consistency.py \ | ||
| --root . \ | ||
| --pin-file external/QuantPlatformKit/QPK_PIN |
There was a problem hiding this comment.
Under the QPK #202 script this step depends on, check_qpk_pin_consistency.py scans cross-file QSL pin drift. This repo's qsl.toml still pins QuantPlatformKit at 37c819... while this change moves pyproject.toml/uv.lock to 8378e939..., so enabling this step makes CI fail before tests even if the unit-test constant is fixed. Include qsl.toml in the pin update or hold off on running the expanded gate.
Useful? React with 👍 / 👎.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
1 participant
Summary
quant-platform-kitgit pin 对齐QPK_PIN（8378e93）uv.lock，CI 新增 pin/lock 一致性检查依赖
check_qpk_pin_consistency.py）Test plan
Made with Cursor