Skip to content

[codex] add CI workflow lint and whitespace checks #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 3 commits into from
Jul 2, 2026
Merged

[codex] add CI workflow lint and whitespace checks #52

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b755644
ci: add workflow lint and whitespace checks
Pigbibi Jul 2, 2026
de26888
ci: fetch full history for whitespace checks
Pigbibi Jul 2, 2026
ba7d237
chore: retrigger branch protection checks
Pigbibi Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,34 @@ permissions:
contents: read

jobs:
actionlint:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- name: Checkout
uses: actions/checkout@v6

- name: Actionlint
uses: docker://rhysd/actionlint:1.7.12

test:
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- name: Checkout
uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Check whitespace
run: |
set -euo pipefail
if [ "${{ github.event_name }}" = "pull_request" ]; then
git fetch --no-tags --depth=1 origin "${{ github.base_ref }}"
git diff --check "origin/${{ github.base_ref }}...HEAD"

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Deepen checkout before triple-dot diffing

In pull_request runs, the checkout step above uses the default depth-1 checkout of the PR merge commit, and this fetch adds only the base tip. Git documents the A...B diff form as requiring the merge base between the two commits; with both refs shallow there is no merge base, so git diff --check "origin/${{ github.base_ref }}...HEAD" exits with fatal: ... no merge base and blocks PR CI before tests. Please deepen/unshallow the checkout or diff against a fetched base SHA without requiring a merge base.

Useful? React with 👍 / 👎.

else
git diff-tree --check --no-commit-id --root -r HEAD
fi

- name: Resolve QuantPlatformKit ref
id: quant-platform-kit-ref
Expand Down
Loading