Skip to content

chore: document QSL legacy dependency reason #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 3 commits into from
Jul 4, 2026
Merged

chore: document QSL legacy dependency reason #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b5254c
chore: document QSL legacy dependency reason
Pigbibi Jul 4, 2026
b414b95
chore: align QSL bundle to 2026.07.2
Pigbibi Jul 4, 2026
24e054f
test: expect QSL bundle 2026.07.2
Pigbibi Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ description = "Live-pool rotation pipelines for crypto strategy runtime compatib
readme = "README.md"
requires-python = ">=3.11"
dependencies = [
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@7032cde4547e7ec59af15df8935d142461a77051",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@37c81901160c5b31127a27dba1c63944933fb6bf",
"pandas==3.0.3",
"numpy==2.4.6",
"requests==2.34.2",
Expand Down
3 changes: 2 additions & 1 deletion qsl.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ repo = "CryptoLivePoolPipelines"
tier = "pipeline"
ring = 2
allow_legacy = true
legacy_reason = "requirements.txt and requirements-lock.txt remain for runtime deployment compatibility."
enforce_bundle = false
artifact_contract = "docs/integration_contract.md"
snapshot_contract = "docs/integration_contract.md"


[qsl.compat]
bundle = "2026.07.1"
bundle = "2026.07.2"

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the QSL bundle assertion

When the repo test suite is run, tests/test_qsl_metadata.py still asserts that qsl.compat.bundle is 2026.07.1, so changing this value to 2026.07.2 makes python -m pytest tests/test_qsl_metadata.py tests/test_monthly_publish_workflow_config.py -q fail before any compatibility checks can pass. Update the test fixture/assertion alongside the metadata bump, or keep the bundle value unchanged.

Useful? React with 👍 / 👎.

2 changes: 1 addition & 1 deletion requirements-lock.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@7032cde4547e7ec59af15df8935d142461a77051
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@37c81901160c5b31127a27dba1c63944933fb6bf
pandas==3.0.3
numpy==2.4.6
requests==2.34.2
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@7032cde4547e7ec59af15df8935d142461a77051
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@37c81901160c5b31127a27dba1c63944933fb6bf

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the dependency-pin test with this bump

In the same test run, tests/test_monthly_publish_workflow_config.py::test_real_publish_dependency_is_locked still looks for the old QuantPlatformKit SHA, so this changed requirement causes the lock-check test to fail even though requirements.txt and requirements-lock.txt were both bumped. The hard-coded QPK_DEPENDENCY assertion needs to be updated with this new SHA as part of the dependency-pin change.

Useful? React with 👍 / 👎.

pandas>=3.0.3
numpy>=2.4.6,<2.5
requests>=2.34.2
Expand Down
2 changes: 1 addition & 1 deletion tests/test_monthly_publish_workflow_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
README_ZH_PATH = PROJECT_ROOT / "README.zh-CN.md"
QPK_DEPENDENCY = (
"quant-platform-kit @ "
"git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@7032cde4547e7ec59af15df8935d142461a77051"
"git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@37c81901160c5b31127a27dba1c63944933fb6bf"
)


Expand Down
4 changes: 2 additions & 2 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading