Skip to content

chore: add qsl compat metadata baseline#108

Merged
Pigbibi merged 2 commits into
mainfrom
codex/qsl-compat-pipeline-v1
Jul 3, 2026
Merged

chore: add qsl compat metadata baseline#108
Pigbibi merged 2 commits into
mainfrom
codex/qsl-compat-pipeline-v1

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Why\nAdd qsl.toml compatibility metadata and minimal metadata smoke tests for unified QSL compat-mode onboarding.\n\n## Scope\n- Add qsl.toml with tier/research|pipeline, ring=2, compat bundle=2026.07.0, and artifact/snapshot contract paths where applicable.\n- Fill missing uv.lock for pyproject repos where absent (except existing lock coverage).\n- For CryptoLivePoolPipelines, migrate legacy requirements-only repo to pyproject + uv.lock and pin QPK lock target.\n- Add minimal metadata test: tests/test_qsl_metadata.py.\n\n## Validation\n- uv sync --frozen --extra test\n- uv run pytest tests/test_qsl_metadata.py\n- git diff --check

Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 714a8b9f53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

import tomllib


def test_qsl_metadata_has_compat_bundle() -> None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Make the QSL smoke test discoverable by CI

In the checked CI workflow (.github/workflows/ci.yml), the test step runs python -m unittest discover -s tests -v, but this new pytest-style module-level function is not collected by unittest (running python -m unittest tests.test_qsl_metadata -v reports 0 tests). As a result, the only smoke test for the new qsl.toml metadata never runs in the existing CI path; convert it to a unittest.TestCase method or update CI to invoke pytest.

Useful? React with 👍 / 👎.

Comment thread pyproject.toml
Comment on lines +30 to +33
package-dir = {"" = "src"}

[tool.setuptools.packages.find]
where = ["src"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Package the existing src namespace

With package-dir = {"" = "src"} plus package discovery under src, setuptools treats the src/ directory as the package root instead of packaging the existing src package itself. This repo's scripts and tests import modules as src.* (for example from src.config import load_config), so wheel/non-checkout installs created from this new pyproject.toml will omit src/config.py and the other src.* modules; either discover packages from the repo root or move the code under a package below src.

Useful? React with 👍 / 👎.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi merged commit b91549b into main Jul 3, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/qsl-compat-pipeline-v1 branch July 3, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant