[codex] register chinext growth momentum quality snapshot#33
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 139a9483b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| ) | ||
|
|
||
| cn_chinext_growth_momentum_quality_snapshot_manifest = _manifest( |
There was a problem hiding this comment.
Register the new snapshot manifest in MANIFESTS
When callers look up the newly registered profile through the manifest registry, get_strategy_manifest("cn_chinext_growth_momentum_quality_snapshot") still indexes MANIFESTS, but this new manifest is never inserted into that dict below. Direct imports of the variable work, but platform/discovery code that resolves manifests by profile will get a KeyError for this profile despite the catalog and docs saying it is registered.
Useful? React with 👍 / 👎.
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Summary
cn_chinext_growth_momentum_quality_snapshotas a research-only snapshot-backed profile.Test Plan
PYTHONPATH=src python3 -m pytest -q tests/test_catalog.pyPYTHONPATH=src python3 -m pytest -q tests/test_cn_chinext_growth_momentum_quality_snapshot.py tests/test_entrypoints.py tests/test_catalog.pyPYTHONPATH=src python3 -m pytest -q