Skip to content

fix: publish complete ETF market history#20

Merged
Pigbibi merged 1 commit into
mainfrom
codex/strict-akshare-history-20260711
Jul 10, 2026
Merged

fix: publish complete ETF market history#20
Pigbibi merged 1 commit into
mainfrom
codex/strict-akshare-history-20260711

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • fail closed when any requested ETF history is missing
  • retry and pace AkShare requests
  • publish a scheduled real market-history artifact for strategy drift preflight

Verification

  • PYTHONPATH=src python3 -m pytest -q tests/test_akshare_staging.py tests/test_publish_market_history_workflow.py
  • python3 -m ruff check ...
  • actionlint .github/workflows/publish-market-history.yml
  • git diff --check

Co-Authored-By: Codex <noreply@openai.com>
@github-actions

Copy link
Copy Markdown

🤖 Codex PR Review

Merge allowed: 1 finding(s) reported but none are blocking

ℹ️ Other Findings

1. 🟡 [MEDIUM] Bug in src/cn_equity_snapshot_pipelines/akshare_market_history.py

Changing the guard from if not frames: to if errors: means an empty symbols input now falls through to pd.concat(frames, ignore_index=True), which raises ValueError: No objects to concatenate. Before this patch, the function failed in a controlled way when no frames were produced; after this change, callers that pass an empty list or tuple will get an uncaught crash instead. (line 114)

Suggestion: Restore an explicit empty-result guard before pd.concat, for example by checking if not requested_symbols or if not frames and raising a deterministic RuntimeError/ValueError with a clear message.


Review by Codex PR Review bot • PR

@Pigbibi Pigbibi merged commit 37b6cd8 into main Jul 10, 2026
3 checks passed
@Pigbibi Pigbibi deleted the codex/strict-akshare-history-20260711 branch July 10, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant