Skip to content

chore(qsl): phase2 compat 2026.07.1 + dependency refs#11

Merged
Pigbibi merged 1 commit into
mainfrom
codex/qsl-compat-phase2-pipeline
Jul 3, 2026
Merged

chore(qsl): phase2 compat 2026.07.1 + dependency refs#11
Pigbibi merged 1 commit into
mainfrom
codex/qsl-compat-phase2-pipeline

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update qsl.compat.bundle to 2026.07.1
  • Update CN strategy git ref in pyproject to main HEAD ref
  • Sync uv.lock to match dependency ref
  • Update qsl metadata smoke test expectation

Validation

  • uv lock --check
  • uv run pytest tests/test_qsl_metadata.py -q
  • git diff --check

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi merged commit 190ef3f into main Jul 3, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/qsl-compat-phase2-pipeline branch July 3, 2026 09:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52a75e1cdd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml
dependencies = [
"pandas>=2.0",
"cn-equity-strategies @ git+https://github.com/QuantStrategyLab/CnEquityStrategies.git@357dba7e8896a7f488a484d4a3eea33894708ab9",
"cn-equity-strategies @ git+https://github.com/QuantStrategyLab/CnEquityStrategies.git@c6d680d6d2690fe6ff77872355719751c021f9a0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Refresh the transitive platform-kit pin

The newly pinned c6d680d CnEquityStrategies commit declares quant-platform-kit @ ...0063af3b4a974650ea58a7d3f26dd1b94f65d3e8 in its own pyproject.toml, but this repo's uv.lock still resolves quant-platform-kit to the old d18fe32... ref at uv.lock:792. For uv-based installs the lock is the source of truth, so this change installs the strategy library against a different platform-kit commit than the one its metadata now requires, making locked environments diverge from pip/CI installs and potentially fail pip check or runtime compatibility once dependencies are available. Please regenerate the lock so the transitive Git ref matches the new strategy commit.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant