[codex] reconcile cloud runtime drift#242
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9bc884dbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SYNC_PLAN_JSON: ${{ steps.strategy_requirements.outputs.sync_plan_json }} | ||
| run: | | ||
| set -euo pipefail | ||
| python3 scripts/reconcile_cloud_runtime.py reconcile-traffic |
There was a problem hiding this comment.
Verify mounts before routing traffic
When the service has traffic pinned to an older revision (the drift this step is correcting), this command moves 100% of production traffic to the latest revision before the following Verify strategy plugin mounts step runs. If the env sync just wrote a bad or missing SCHWAB_STRATEGY_PLUGIN_MOUNTS_JSON, the verification can still fail, but traffic has already been shifted to the unverified revision; run this reconciliation after that verification succeeds.
Useful? React with 👍 / 👎.
Summary
Validation