Skip to content

[codex] reconcile cloud runtime drift#242

Merged
Pigbibi merged 1 commit into
mainfrom
codex/cloud-runtime-reconcile-20260707
Jul 6, 2026
Merged

[codex] reconcile cloud runtime drift#242
Pigbibi merged 1 commit into
mainfrom
codex/cloud-runtime-reconcile-20260707

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add Schwab single-service Cloud Run traffic reconciler
  • replace inline legacy scheduler deletion with whitelist cleanup
  • keep existing scheduler/env/plugin workflow behavior covered by tests

Validation

  • python3 -m unittest tests/test_reconcile_cloud_runtime.py -v
  • bash tests/test_sync_cloud_run_env_workflow.sh
  • python3 YAML parse for .github/workflows/sync-cloud-run-env.yml
  • git diff --check

Co-Authored-By: Codex <noreply@openai.com>
@cursor

cursor Bot commented Jul 6, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi Pigbibi merged commit 97318e2 into main Jul 6, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/cloud-runtime-reconcile-20260707 branch July 6, 2026 22:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9bc884dbb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

SYNC_PLAN_JSON: ${{ steps.strategy_requirements.outputs.sync_plan_json }}
run: |
set -euo pipefail
python3 scripts/reconcile_cloud_runtime.py reconcile-traffic

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Verify mounts before routing traffic

When the service has traffic pinned to an older revision (the drift this step is correcting), this command moves 100% of production traffic to the latest revision before the following Verify strategy plugin mounts step runs. If the env sync just wrote a bad or missing SCHWAB_STRATEGY_PLUGIN_MOUNTS_JSON, the verification can still fail, but traffic has already been shifted to the unverified revision; run this reconciliation after that verification succeeds.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant