[codex] pilot uv dependency sync#234
Conversation
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 556839b3e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| && python -m pip install -r requirements.txt -c constraints.txt | ||
| COPY pyproject.toml uv.lock ./ | ||
| RUN python -m pip install --upgrade pip uv \ | ||
| && uv sync --frozen --no-dev --no-install-project |
There was a problem hiding this comment.
Keep uv.lock in sync with shared-package pins
When the shared-package pins advance, scripts/check_qpk_pin_consistency.py only scans requirements*.txt, constraints*.txt, and pyproject.toml, while uv.lock stores the actual git sources as ?rev=.... Because this Docker build now installs from uv.lock with uv sync --frozen (per uv sync --help, frozen syncs without updating the lockfile), a normal pin update can leave the image installing the old QuantPlatformKit/UsEquityStrategies revisions even after the pin files were fixed. Please have the pin update/guard also regenerate or validate uv.lock before using frozen syncs.
Useful? React with 👍 / 👎.
Summary
pyproject.toml+uv.lock.requirements.txt/constraints.txtin place for compatibility while the platform migration is piloted.--no-install-projectbecause this repo still has asrcsetuptools layout configured but nosrc/package migration in this PR.Validation
uv sync --frozen --extra test --no-install-projectuv run --no-sync python scripts/check_qpk_pin_consistency.pyuv run --no-sync python -m pytest -q tests/test_uv_dependency_workflow.py tests/test_dependency_pin_guard.pybash tests/test_sync_cloud_run_env_workflow.shuv run --no-sync ruff check --exclude external .actionlint .github/workflows/ci.yml .github/workflows/sync-cloud-run-env.ymlgit diff --checkdocker build -t charles-schwab-platform-uv-poc:local .Known caveat
uv run --no-sync python -m pytest -qis still not green on the current repo baseline:24 failed, 139 passed, 1 warning. The failures are existing broader runtime/test-stub mismatches and are not mixed into this dependency-management PoC.