Skip to content

chore: update qpk dependency pin#230

Merged
Pigbibi merged 2 commits into
mainfrom
codex/update-qpk-pin-20260703
Jul 3, 2026
Merged

chore: update qpk dependency pin#230
Pigbibi merged 2 commits into
mainfrom
codex/update-qpk-pin-20260703

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary\n- update quant-platform-kit dependency to QPK_PIN 0063af3, which includes the plugin Telegram manual-review fix\n\n## Tests\n- python3.11 scripts/check_qpk_pin_consistency.py

Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36b4bf426c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread requirements.txt
google-auth
numpy
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@b9a7df85cfc848cebcc3aa6e1d77ec34ca7611ab
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the QPK constraint alongside the requirement

When building the Docker image, Dockerfile:13-16 copies both dependency files and runs python -m pip install -r requirements.txt -c constraints.txt. This line now requests QPK at 0063af3, while constraints.txt:6 still constrains the same package to b9a7df8; pip install --help defines -c, --constraint as constraining versions with the given file, and a local dry-run with two different direct refs reports ResolutionImpossible, so container builds using the Dockerfile will fail until the constraint pin is updated too.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi enabled auto-merge (squash) July 3, 2026 05:02
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi merged commit 88f98de into main Jul 3, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/update-qpk-pin-20260703 branch July 3, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant