Read the SCF sample from high_dim_data main#50
Merged
Conversation
Repoints the SCF+ wealth sample off the update_scf_noweights branch and onto main. This lecture has fetched its data from an unmerged PR's branch since 2023 — a build pinned to a non-default ref, which any branch cleanup would silently break, and which is why that branch cannot be deleted today. Uses the github.com/QuantEcon/high_dim_data/raw/main/… form rather than media.githubusercontent.com. Both serve this LFS-tracked file, but only /raw/ keeps working if the file ever stops being LFS — which it will when the data consolidation folds high_dim_data into data-lectures, a repo that deliberately drops high_dim_data's blanket "*.csv filter=lfs" rule. Repointing to /raw/ now means this URL does not have to change again then. The URL form is verified against the sibling SCF_plus_mini.csv, which is already on main and LFS-tracked: /raw/main/ serves it as real CSV, while raw.githubusercontent.com serves LFS pointer text for the same file. Blocked until QuantEcon/high_dim_data#6 merges — the data file exists only on the branch, so this URL 404s until then. That PR has been open, mergeable and conflict-free since 2023-04-28. Part of QuantEcon/meta#337 See QuantEcon/meta#336 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for beautiful-dodol-cb9543 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📖 Netlify Preview Ready! Preview URL: https://pr-50--beautiful-dodol-cb9543.netlify.app (e27393c) ✨ Browse the preview at the URL above. |
There was a problem hiding this comment.
Pull request overview
This PR updates the SCF+ wealth sample URL used in lectures/mle.md to fetch the dataset from the main branch of QuantEcon/high_dim_data, avoiding reliance on a non-default branch ref.
Changes:
- Repointed
SCF_plus_mini_no_weights.csvdownload URL fromupdate_scf_noweightstomainusing thegithub.com/.../raw/main/...form.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repoints the SCF+ wealth sample in
mle.mdoff theupdate_scf_noweightsbranch ofhigh_dim_dataand ontomain. Part of risk 1 in QuantEcon/meta#337.What this fixes
This lecture has fetched its data from an unmerged PR's branch since 2023:
A lecture build pinned to a non-default ref is a build that any branch cleanup breaks silently — and that pin is precisely why the branch could not be deleted. #6 put the file on
main; this points the lecture at it.This is a 4-repo set, not a one-liner
The pin was tracked as living in
lecture-python-introalone. An org-wide code search shows four source repos carry it, each with its own copy ofmle.md. All four get the identical change, on the same branch name (datasets/repoint-scf-main) with the same commit subject, so the set tracks as one:lecture-python-introlecture-intro.zh-cnlecture-wasmtest-lecture-python-intromle.md(it is in its_toc.yml, withci.ymlandlinkcheck.yml)lecture-python-intro.notebooksalso references it, but it is a generated artifact and self-heals on the next rebuild. Theupdate_scf_noweightsbranch may only be deleted once all four of these merge — that is the last step of meta#337 risk 1, and it is the only destructive one.Why the
/raw/form and notmedia.githubusercontent.comBoth serve this LFS-tracked file today. Only
github.com/.../raw/main/...also works if the file ever stops being LFS — which it will, when the consolidation foldshigh_dim_dataintodata-lectures(PLAN Phase 3), a repo that deliberately dropshigh_dim_data's blanket*.csv filter=lfsrule. Repointing to/raw/now means this URL never has to change again.Verification
Checked end-to-end against
mainafter #6 merged:maincarries the same OID the branch served —sha256:c3b2c78a…, 75902999 bytes — so lecture output cannot change. This is the whole migration-integrity question, answered without downloading twice.github.com/.../raw/main/...→ 200, real CSV (year,n_wealth,t_income,l_income,nw_groups,ti_groups), 302ing to the LFS media host.mle.md's exact pipeline against the new URL: 1,672,214 rows fetched, 108,783 after theyear == 2016andn_wealth > 1filters, and a deterministic 10,000-row sample (random_state=1234, mean 6.56 in $100,000 units).raw.githubusercontent.com/.../main/...serves LFS pointer text, not data — verified against the siblingSCF_plus_mini.csv, which was already onmain. Using that form would have failed as a parse error rather than an obvious hosting bug.Part of QuantEcon/meta#337
See QuantEcon/meta#336