Skip to content

[opt_transport] Update Description on outputs of LP solvers - #465

Merged
mmcky merged 4 commits into
mainfrom
fix-opttrans
Jun 19, 2025
Merged

[opt_transport] Update Description on outputs of LP solvers#465
mmcky merged 4 commits into
mainfrom
fix-opttrans

Conversation

@HumphreyYang

Copy link
Copy Markdown
Member

This PR fixes #461.

@github-actions

github-actions Bot commented Jun 17, 2025

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request June 17, 2025 12:38 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request June 17, 2025 12:39 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request June 18, 2025 00:27 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request June 18, 2025 00:27 Inactive
@HumphreyYang
HumphreyYang requested a review from mmcky June 18, 2025 04:44
@HumphreyYang

Copy link
Copy Markdown
Member Author

Hi @mmcky,

I think this is ready for your review.

I tried to enforce both functions to use simplex method but the sympy gives deprecation warning.

Please let me know if there is anything I should update!

@mmcky

mmcky commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

thanks @HumphreyYang -- I'll review this soon.

@mmcky mmcky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @HumphreyYang this looks great. Just had one question.

Comment thread lectures/opt_transport.md Outdated
@HumphreyYang

Copy link
Copy Markdown
Member Author

Many thanks @mmcky, I just removed the space!

@mmcky

mmcky commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Thanks for your work on this @HumphreyYang -- its great.

@github-actions
github-actions Bot temporarily deployed to pull request June 19, 2025 00:10 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request June 19, 2025 00:11 Inactive
@mmcky
mmcky merged commit c5c0174 into main Jun 19, 2025
@mmcky
mmcky deleted the fix-opttrans branch June 19, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[opt_transport] Update the descriptions on outputs of LP solvers

2 participants