-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
DOCS: Comprehensive documentation review and improvements #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… functions Co-authored-by: mmcky <[email protected]>
…erage analysis Co-authored-by: mmcky <[email protected]>
What is our convention about docs for methods with QuantEcon.py/quantecon/markov/core.py Lines 119 to 120 in 0a4af14
|
Thanks @oyamad -- I think they are considered Attributes in It is certainly how
|
@oyamad these changes appear to be surprisingly accurate. I will take a closer look tomorrow but I am pretty impressed with copilot, it's really great having an AI agent that knows the context of GitHub. |
""" | ||
Whether the Markov chain is irreducible. | ||
|
||
Returns | ||
------- | ||
bool | ||
True if the Markov chain is irreducible, False otherwise. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmcky So a docsting shouldn't be attached to a function with @property
? (This is just one example.)
This PR addresses the comprehensive documentation review requested in issue #788, significantly improving docstring quality, consistency, and coverage across the QuantEcon.py codebase.
Key Improvements
Fixed Missing Docstrings (32% reduction in issues)
BetaBinomial
property methods (mean
,std
,var
,skew
) with proper docstrings including Returns sectionsMarkovChain
properties (digraph
,is_irreducible
,communication_classes
,recurrent_classes
,period
,cyclic_classes
, etc.)str2num
,payoff_profile_array
, and BRDplay
methods with proper Parameters and Returns sectionsstd_norm_cdf
androw_build_mat
functionsgammaln
,fix
functions and fixed missingusesqrtm
parameter documentation inqnwnorm
Enhanced Parameter and Returns Documentation
overwrite
parameter to proper section ingth_solve
)Documentation Coverage Verification
Examples of Improvements
Before:
After:
Impact
The documentation now provides much clearer guidance for users while maintaining the high mathematical rigor and code quality standards of the QuantEcon library.
Fixes #788.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.