fix: rgba parsing not handling negative alpha values#89
Open
chodorowicz wants to merge 1 commit intoQix-:masterfrom
Open
fix: rgba parsing not handling negative alpha values#89chodorowicz wants to merge 1 commit intoQix-:masterfrom
chodorowicz wants to merge 1 commit intoQix-:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This recent PR https://github.com/Qix-/color-string/pull/78 added support for scientific notation of numbers in
rgba()regex, but it missed the fact that values with negative exponents like1E-7are also valid.In this demo there are several examples how negative exponents work and are valid in browsers exponents in rgba values