Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion qiskit/circuit/library/quantum_volume.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ def quantum_volume(
`arXiv:1811.12926 <https://arxiv.org/abs/1811.12926>`__
"""
if isinstance(seed, np.random.Generator):
seed = seed.integers(0, dtype=np.uint64)
max_value = np.iinfo(np.int64).max
seed = seed.integers(max_value, dtype=np.int64)
depth = depth or num_qubits
return QuantumCircuit._from_circuit_data(qv_rs(num_qubits, depth, seed))
6 changes: 6 additions & 0 deletions releasenotes/notes/qv-rng-4bc9572d2df93671.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
fixes:
- |
:func:`qiskit.circuit.library.quantum_volume` was updated to handle a
:class:`numpy.random.Generator` as input for its ``seed`` argument.
Previously, such a generator argument would result in a ``TypeError``.
9 changes: 9 additions & 0 deletions test/python/circuit/library/test_quantum_volume.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
import unittest

from test.utils.base import QiskitTestCase

import numpy as np

from qiskit.circuit.library import QuantumVolume
from qiskit.circuit.library.quantum_volume import quantum_volume

Expand Down Expand Up @@ -50,6 +53,12 @@ def test_qv_function_seed_reproducibility(self):
right = quantum_volume(10, 10, seed=4196)
self.assertEqual(left, right)

rng = np.random.default_rng(256)
left = quantum_volume(10, 10, seed=rng)
rng = np.random.default_rng(256)
right = quantum_volume(10, 10, seed=rng)
self.assertEqual(left, right)


if __name__ == "__main__":
unittest.main()