Skip to content

Feat/migrate get jobs endpoint #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Conversation

paaragon
Copy link
Collaborator

@paaragon paaragon commented Jul 21, 2025

  • I have added the tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Summary

  • Migrated /jobs and /jobs/provider endpoints to new architecture
  • Added new filters: status, function and created_after date
  • Added tests to cover new filters
  • Added a new ProgramSummarySerializer so we return less info about the program in the job lists

Details

After trying multiple solutions, I think the best pattern is to return a QuerySet in the repository but not propagate it to the endpoint. The use-case should return a business object, not the QuerySet.

I created the create_paginated_response utility method that should be used in future endpoints to maintain consistency between responses.

Also, the previous response was returning different response types. I removed the non-paginated response because it wasn't being used in the client.

@paaragon paaragon marked this pull request as ready for review July 28, 2025 13:55
@paaragon paaragon requested a review from a team as a code owner July 28, 2025 13:55
@paaragon paaragon marked this pull request as draft July 28, 2025 13:55
@paaragon paaragon marked this pull request as ready for review July 29, 2025 10:06
@Tansito
Copy link
Member

Tansito commented Aug 12, 2025

As we commented internally we are going to close this PR and do the review in the #1695 as it was just created with this branch as base and @korgan00 started a review there.

@Tansito Tansito closed this Aug 12, 2025
@Tansito Tansito deleted the feat/migrate-get-jobs-endpoint branch August 12, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants