Feat/migrate get jobs endpoint #1685
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/jobs
and/jobs/provider
endpoints to new architecturestatus
,function
andcreated_after
dateProgramSummarySerializer
so we return less info about the program in the job listsDetails
After trying multiple solutions, I think the best pattern is to return a QuerySet in the repository but not propagate it to the endpoint. The use-case should return a business object, not the QuerySet.
I created the
create_paginated_response
utility method that should be used in future endpoints to maintain consistency between responses.Also, the previous response was returning different response types. I removed the non-paginated response because it wasn't being used in the client.