Conversation
Remove AdventureSerializer.asJson() usage that was causing hologram text to display as raw JSON strings in Minecraft 1.8 and earlier versions. The legacy serialization path now uses legacyComponentSerializer which properly converts components to legacy color codes that older clients understand.
Contributor
Author
this is how it looked before this fix
|
Owner
|
Have you tested this on a version like 1.12? |
Contributor
Author
|
legacySerialization is true only when the server version is lower than 1.9 so it should work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hologram text was displaying as raw JSON strings in Minecraft 1.8 and earlier versions. This occurred because the legacy serialization path was using AdventureSerializer.asJson() which output JSON format that older clients couldn't properly parse.