Skip to content

feat: adding missing parameters and attribute documentation #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

Lumabots
Copy link
Contributor

Summary

Information

  • This PR fixes an issue.
  • [] This PR adds something new (e.g. new method or parameters).
  • [] This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lumabots
Copy link
Contributor Author

sorry i renamed the branch and it deleted the other one

@Lumabots Lumabots changed the title Channel docs: Improve docstrings and attribute documentation Apr 30, 2025
Lumabots and others added 2 commits May 1, 2025 19:45
Co-authored-by: plun1331 <[email protected]>
Signed-off-by: Lumouille <[email protected]>
Co-authored-by: plun1331 <[email protected]>
Signed-off-by: Lumouille <[email protected]>
@Lumabots
Copy link
Contributor Author

could this pls be review and merged asap since it fix some bugs ?

Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request title is also misleading.

Lumabots and others added 2 commits June 20, 2025 09:02
@Lumabots
Copy link
Contributor Author

This pull request title is also misleading.

if you have a better name in mind i'll be happy to change it

Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix markdown

@JustaSqu1d
Copy link
Member

This pull request title is also misleading.

if you have a better name in mind i'll be happy to change it

This pull request isn't a documentation change.

Co-authored-by: JustaSqu1d <[email protected]>
Signed-off-by: Lumouille <[email protected]>
@Lumabots Lumabots changed the title docs: Improve docstrings and attribute documentation feats: adding missing parameters and attribute documentation Jun 20, 2025
@Lumabots Lumabots changed the title feats: adding missing parameters and attribute documentation feat: adding missing parameters and attribute documentation Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants