-
Notifications
You must be signed in to change notification settings - Fork 83
Fixing carriage return error. Issue #326 #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think stripping it is fine. Can you add a test?
autoflake.py
Outdated
else: | ||
# Eğer split işlemi beklenen şekilde çalışmazsa | ||
indentation = '' | ||
imports = line.replace('\r', '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have an example of when this happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes in issue #326
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is my pull request okay to merge? Do you have any other feedback for me? If so, I can update the code again. @fsouza
I ran test_autoflake.py and this is the response i get: ..............'expand-star-imports' in the config file should be a boolean
|
#326