Skip to content

Baivab updated python-package.yml #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Baivab updated python-package.yml #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 18 additions & 31 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,40 +24,27 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install pip
run: python -m pip install --upgrade pip
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the upgrade command for pips?

python -m pip install flake8
python -m pip install --upgrade setuptools wheel twine
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
if [ -f requirements-dev.txt ]; then pip install -r requirements-dev.txt; fi
- name: Lint with flake8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this block of code is required for this project to be run and tested. Please ensure you have read the documentation properly before proceeding

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please review this code is this correct or not? Actually its a first Open Source for me . So I need guidance and review of my pull requests

`name: Python package

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

jobs:
build:

runs-on: ubuntu-latest
strategy:
  fail-fast: false
  matrix:
    python-version: [3.9, 3.11]

steps:
- uses: actions/checkout@v2

- name: Set up Python ${{ matrix.python-version }}
  uses: actions/setup-python@v2
  with:
    python-version: ${{ matrix.python-version }}

- name: Upgrade pip
  run: |
    python -m pip install --upgrade pip

- name: Install dependencies
  run: |
    python -m pip install flake8
    if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
    if [ -f requirements-dev.txt ]; then pip install -r requirements-dev.txt; fi

- name: Lint with flake8
  run: |
    # TODO: stop the build if there are Python syntax errors or undefined names
    flake8 . --count --exit-zero --select=E9,F63,F7,F82 --show-source --statistics
    # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
    flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics

- name: Install package
  run: |
    python setup.py install

- name: Download certificate and private key
  run: |
    wget "https://www.sistemasagiles.com.ar/soft/pyafipws/reingart2021.zip" -O reingart2019.zip
    unzip reingart2019.zip

- name: Copy configuration files
  run: |
    sudo cp conf/rece.ini rece.ini
    sudo cp conf/wslum.ini wslum.ini
    sudo cp conf/wsremcarne.ini wsremcarne.ini
    sudo cp conf/wsltv.ini wsltv.ini
    sudo cp conf/wslsp.ini wslsp.ini

- name: Install pip dependencies
  run: |
    python -m pip install --upgrade setuptools wheel twine

- name: Build package
  run: |
    python setup.py sdist bdist_wheel

- name: Publish distribution 📦 to PyPI
  uses: pypa/gh-action-pypi-publish@master
  with:
    user: __token__
    password: ${{ secrets.PYPI_API_TOKEN }}

- name: Publish distribution 📦 to Test PyPI
  if: secrets.TEST_PYPI_API_TOKEN != ''
  uses: pypa/gh-action-pypi-publish@release/v1
  with:
    user: __token__
    password: ${{ secrets.TEST_PYPI_API_TOKEN }}
    repository_url: https://test.pypi.org/legacy/

- name: Test with pytest
  run: |
    pytest --html=report.html --self-contained-html

- name: Upload test report
  uses: actions/upload-artifact@v2
  if: ${{ always() }}
  with:
    name: report.html
    path: report.html

- name: Coverage Report
  run: |
    pytest --cov-config=.coveragerc --cov-report=html --cov=pyafipws tests/

- name: Upload coverage report
  uses: actions/upload-artifact@v2
  if: ${{ always() }}
  with:
    name: Coverage_Report
    path: htmlcov

`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's your first opensource work
So it's good to always ask especially with issues like deleting code somewhere

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Sir, I might have mistakenly deleted it but updated in the previous code can you please review it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baivab85 First, you need to sign-off the commits and then send a new commit with the changes requested by @HanslettTheDev so that he can review your work again.
Don't worry if you have to send more commits until your work can be approved, that's the process and you gain practice in the meantime.
Thank you for your collaboration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baivab85 Try to push the the github script in this same branch
I noticed some minor changes in it, Just push to this branch so the github runners can execute it so we can see the commit changes per line

run: |
# TODO: stop the build if there are Python syntax errors or undefined names
flake8 . --count --exit-zero --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
- name: Install package
run: |
python setup.py install
- name: Download certificate and private key
run: |
wget "https://www.sistemasagiles.com.ar/soft/pyafipws/reingart2021.zip" -O reingart2019.zip
unzip reingart2019.zip
- name: Copy rece.ini file
run: |
sudo cp conf/rece.ini rece.ini
- name: Copy wslum.ini file
run: |
sudo cp conf/wslum.ini wslum.ini
- name: Copy wsremcarne.ini file
run: |
sudo cp conf/wsremcarne.ini wsremcarne.ini
- name: Copy wsltv.ini file
run: |
sudo cp conf/wsltv.ini wsltv.ini
- name: Copy wslsp.ini file
run: |
sudo cp conf/wslsp.ini wslsp.ini
- name: Build package
run: python setup.py sdist bdist_wheel
- name: Publish distribution 📦 to PyPI
uses: pypa/gh-action-pypi-publish@master
with:
user: __token__
password: ${{ secrets.PYPI_API_TOKEN }}
- name: Publish distribution 📦 to Test PyPI
if: secrets.TEST_PYPI_API_TOKEN != ''
uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
repository_url: https://test.pypi.org/legacy/
- name: Test with pytest
run: |
pytest --html=report.html --self-contained-html
Expand All @@ -67,7 +54,6 @@ jobs:
with:
name: report.html
path: report.html

- name: Coverage Report
run: |
pytest --cov-config=.coveragerc --cov-report=html --cov=pyafipws tests/
Expand All @@ -77,3 +63,4 @@ jobs:
with:
name: Coverage_Report
path: htmlcov