Fix #139 (allow app-user to list home even without explicit entrypoint.py prep)#146
Merged
simonmicro merged 4 commits intonextfrom Apr 11, 2026
Merged
Fix #139 (allow app-user to list home even without explicit entrypoint.py prep)#146simonmicro merged 4 commits intonextfrom
simonmicro merged 4 commits intonextfrom
Conversation
Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
acf69cb to
dee51de
Compare
…ixes #139 Signed-off-by: simonmicro <simon@simonmicro.de>
dee51de to
7490ba9
Compare
There was a problem hiding this comment.
Pull request overview
Updates the Docker runtime/permissions and startup scripts to address issue #139 where running the container as a non-root user could not import modules from /home/py-kms (e.g., pykms_RpcBind), and to improve startup/shutdown logging and UID/GID handling.
Changes:
- Adjust Dockerfile permission-hardening to make
/home/py-kmstraversable/readable for non-owner users (supporting non-root execution). - Refine
entrypoint.pyUID/GID change logic and logging, including clearer non-root warnings. - Add additional shutdown/termination logs in
start.pyand log level/UID/GID logging in both scripts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
docker/start.py |
Adds shutdown/process termination logging and improves startup log output. |
docker/entrypoint.py |
Updates UID/GID switching logic (better diagnostics + early exits) and improves runtime identity logging. |
docker/docker-py3-kms/Dockerfile |
Changes hardening to 0444/0555 permissions to allow non-root users to traverse/read /home/py-kms. |
docker/docker-py3-kms-minimal/Dockerfile |
Same permission-hardening adjustment as the full image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139