Skip to content

Fix #139 (allow app-user to list home even without explicit entrypoint.py prep)#146

Merged
simonmicro merged 4 commits intonextfrom
bug/no_perm_drop_without_root
Apr 11, 2026
Merged

Fix #139 (allow app-user to list home even without explicit entrypoint.py prep)#146
simonmicro merged 4 commits intonextfrom
bug/no_perm_drop_without_root

Conversation

@simonmicro
Copy link
Copy Markdown
Member

@simonmicro simonmicro commented Apr 11, 2026

Fixes #139

Signed-off-by: simonmicro <simon@simonmicro.de>
Signed-off-by: simonmicro <simon@simonmicro.de>
@simonmicro simonmicro self-assigned this Apr 11, 2026
@simonmicro simonmicro added the bug Something isn't working label Apr 11, 2026
@simonmicro simonmicro force-pushed the bug/no_perm_drop_without_root branch from acf69cb to dee51de Compare April 11, 2026 14:31
…ixes #139

Signed-off-by: simonmicro <simon@simonmicro.de>
@simonmicro simonmicro force-pushed the bug/no_perm_drop_without_root branch from dee51de to 7490ba9 Compare April 11, 2026 14:36
@simonmicro simonmicro changed the title Fix #139 (alllow app-user to list home even without explicit entrypoint.py prep) Fix #139 (allow app-user to list home even without explicit entrypoint.py prep) Apr 11, 2026
@simonmicro simonmicro requested a review from Copilot April 11, 2026 14:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Docker runtime/permissions and startup scripts to address issue #139 where running the container as a non-root user could not import modules from /home/py-kms (e.g., pykms_RpcBind), and to improve startup/shutdown logging and UID/GID handling.

Changes:

  • Adjust Dockerfile permission-hardening to make /home/py-kms traversable/readable for non-owner users (supporting non-root execution).
  • Refine entrypoint.py UID/GID change logic and logging, including clearer non-root warnings.
  • Add additional shutdown/termination logs in start.py and log level/UID/GID logging in both scripts.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
docker/start.py Adds shutdown/process termination logging and improves startup log output.
docker/entrypoint.py Updates UID/GID switching logic (better diagnostics + early exits) and improves runtime identity logging.
docker/docker-py3-kms/Dockerfile Changes hardening to 0444/0555 permissions to allow non-root users to traverse/read /home/py-kms.
docker/docker-py3-kms-minimal/Dockerfile Same permission-hardening adjustment as the full image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker/docker-py3-kms/Dockerfile Outdated
Comment thread docker/docker-py3-kms-minimal/Dockerfile
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@simonmicro simonmicro merged commit 1f3824a into next Apr 11, 2026
2 checks passed
@simonmicro simonmicro deleted the bug/no_perm_drop_without_root branch April 11, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants