Issue 708 sync backend contract registry - #902
Open
deep-bhikadiya wants to merge 5 commits into
Open
Conversation
…n\nImplements short-lived locks for verification review to prevent concurrent\nreview actions. Meets acceptance criteria:\n\n- Review actions (approve/reject/request-resubmission) now require lock ownership\n- Locks expire after configurable duration (default 5 minutes)\n- Stale-lock recovery via scheduled job (every 2 minutes)\n- API responses include conflict details for frontend UX\n\nChanges:\n- Add ReviewLock model to Prisma schema\n- Add ReviewLockService with lock acquire/release/refresh/verify\n- Add ReviewLockScheduler for automatic stale-lock recovery\n- Add lock endpoints: POST /:id/lock, POST /lock/release, POST /lock/refresh\n- Add lock status to inbox listing and verification details\n- Integrate lock verification into review action endpoints\n- Add LockConflictResponse with suggestedAction for frontend guidance\n\nCloses Pulsefy#703
|
@deep-bhikadiya Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Merge Pulsefy/Soter main into the contract-registry branch so CI receives the corrected workspace lockfile and Jest overrides. Remove inherited review-lock lint errors and make the synchronous registry fallback helper accurately non-async. Constraint: PR Pulsefy#902 was 29 upstream commits behind and inherited the same stale root lockfile importer as PR Pulsefy#901. Rejected: Regenerate the stale branch lockfile without syncing main | would duplicate upstream dependency policy and leave the branch outdated. Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep contract registry fallback paths synchronous unless they acquire real asynchronous work. Tested: pnpm 10.34.5 frozen install; targeted ESLint; backend build; 5 documented Jest suites with 50 passing tests Not-tested: Full cross-service suite; GitHub Actions pending push
Contributor
Merge current upstream main while preserving the contract-registry synchronization work. Remove the unused root Prisma 7 toolchain so the repository workflow resolves backend Prisma 6, create the SQLite CI database before migrations, repair the pnpm 9 lock graph, and clear lint blockers inherited from main. Constraint: Backend CI invokes npx prisma from app/backend and installs through pnpm 9. Rejected: Remove the Prisma schema URL | backend remains on Prisma 6, which requires it. Rejected: Change the GitHub workflow | fork workflow edits require maintainer approval and the issue is a package-boundary conflict. Confidence: high Scope-risk: narrow Directive: Keep Prisma CLI ownership in app/backend and avoid a conflicting root Prisma major. Tested: pnpm 9 frozen install; Prisma 6 migration deploy; ESLint fix dry-run; backend build; 690 backend tests; 50 contract-registry tests; Node and Python contract suites. Not-tested: npm package-lock regeneration, which is not consumed by these checks.
…istry Resolve conflicts in logger, soroban adapter, and pnpm-lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aid_escrowcontract ID from the registry artifact when env config is missingCONTRACT_REGISTRY_PATHandCONTRACT_REGISTRY_SYNC_DISABLEDTests
npm run buildnpm test -- --runInBand --forceExit src/deployment-metadata/contract-registry.artifact.spec.ts src/deployment-metadata/contract-registry-sync.service.spec.ts src/deployment-metadata/deployment-metadata.service.spec.ts src/deployment-metadata/contract-config-cache.service.spec.ts src/onchain/onchain.module.spec.tsclose #708