Add footer with updated text #536
Conversation
for more information, see https://pre-commit.ci
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
brian-rose
requested review from
dopplershift and
r-ford
and removed request for
a team
myst.yml
Outdated
| parts: | ||
| footer: | | ||
| :::::{grid} 4 | ||
| :class: items-center |
There was a problem hiding this comment.
The logos don't look exactly centered in the preview, though they look fine on the portal.
There was a problem hiding this comment.
The preview shows exactly how they will look. They aren't exactly centered because the 2i2c logo has much narrower width than the other logos.
I don't know why :class: items-center doesn't center each image in its grid element. Maybe there's a different CSS class that we can use. But I'm not very knowledgeable about this.
There was a problem hiding this comment.
```{image} <url>
:align: center
```
May help here. I haven't tried locally
myst.yml
Outdated
| :::::{grid} 4 | ||
| :class: items-center | ||
|
|
||
| ```{image} https://raw.githubusercontent.com/ProjectPythia/pythia-config/main/logos/UAlbany.svg |
There was a problem hiding this comment.
I think the slightly taller UAlbany logo (Minerva 2 on this page) would fit better with the size of the other logos. Also, I think it would look better if all logos had the same height.
There was a problem hiding this comment.
Do you like the "gold with black text" version, purple & white, or black & white here?
There was a problem hiding this comment.
I'd say gold & black.
This isn't high priority, but if there's an option to change it based on light/dark mode, it would be nice to have gold & white in dark mode (and similar for the other logos if available).
There was a problem hiding this comment.
Figuring out how to support different images in the footer for dark and light mode is not in scope for now, but please open an issue to track it.
There was a problem hiding this comment.
These classes should work, though I'm not sure how hidden divs will interact with grid numbering. That can be for the future once the footer lives upstream, though.
There was a problem hiding this comment.
I confirmed locally that they do work. We can specify light and dark mode images and the grid will behave appropriately (now or in the future 😉 )
|
Trying to get the footer to look the way I want it has led me down an unintended rabbit hole. I'm putting this PR back into draft mode, and I think I'll go ahead with the JOSE submission without the footer in place. For the record, here are a few things I've learned:
even if shared footers are not yet supported.
|
Moves footer to external markdown (for now, can live in myst.yml if needed for upstream.) Refactors logo row and NSF row to flex rows with responsive widths and matching heights.
Closes #530
This PR temporarily adds a footer directly to Foundations until the shared upstream footer problem is resolved (ProjectPythia/projectpythia.github.io#530).
This PR also modifies the footer layout and text, following recent discussions. The footer text makes more specific claims about which parts of the Pythia content were supported by NSF awards, and updates the statement to include the current awards.
Finally, I included the 2i2c logo so that the collection of logos fully represents the current set of institutions covered by our NSF awards.
I'd like to settle on the new text here, and use this as a template for the upstream shared footer. We can also update the temporary footer on the portal site to match this once we settle and merge this.