Fix trash cleanup deleting bottles, vials, medipens, etc. that still contain reagents.#883
Open
BramvanZijp wants to merge 2 commits intoProjectOmu:masterfrom
Open
Fix trash cleanup deleting bottles, vials, medipens, etc. that still contain reagents.#883BramvanZijp wants to merge 2 commits intoProjectOmu:masterfrom
BramvanZijp wants to merge 2 commits intoProjectOmu:masterfrom
Conversation
…contain reagents.
github-actions
Bot
added
the
S: Untriaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Title. The SpaceGarbage component is now added/removed in the same situations where the Trash tag is added/removed, meaning only the empty ones will be marked as trash, adding and removing the component as the container is emptied and refilled.
Why / Balance
BSOs, Paramedics, Doctors, etc. etc. all use vials/bottles to carry a small amount of chems. However, if a trash cleanup happens, all of those are gone, which should not be the case. Trash cleanup should not have a major impact on players, such as by deleting their chems. This is especially relevant to the BSO chemical kit, as that loses them chems that are very hard to replace.
Technical details
The TrashOnSolutionEmpty Component already exists to add and remove the trash TAG, I have simply modified that system to also add and remove the garbage COMPONENT.
Media
Small fixes/refactors are exempt, though I have tested it ingame.
Requirements
Changelog
🆑 BramvanZijp