Github Actions and Github Container Registry implementation#92
Open
SLAzurin wants to merge 2 commits intoProjectAsakura:masterfrom
Open
Github Actions and Github Container Registry implementation#92SLAzurin wants to merge 2 commits intoProjectAsakura:masterfrom
SLAzurin wants to merge 2 commits intoProjectAsakura:masterfrom
Conversation
SLAzurin
changed the title
Contributor
Author
|
I will be finishing the tests on my local repo first before pushing here :) |
SLAzurin
force-pushed
the
dockerfile-publish-gh-actions
branch
from
3a70dec to
d032a45
Compare
Contributor
Author
|
I recently discovered that when GH Actions pushes the docker image first, the image will already be publicly available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-requisite:
Enable public packages for containers: gh packages settings
simply tick the checkbox in public packages and save.
in the ProjectAsakura/Bayshore, change the gh actions settings
Under Workflow permissions, change it to Read repository contents and packages permissions.
Review, suggest code changes if necessary, approve this pr :)
Then it should be mergable.
This pr will build and push bayshore in 2 architectures arm64 and x64.
I removed the copy for config.json into the container since this should be a generic image.