Skip to content

test: rule fixture matrix edge cases (L5B)#76

Open
Nelson Spence (Fieldnote-Echo) wants to merge 2 commits intomainfrom
test/L5B-rule-fixture-batch
Open

test: rule fixture matrix edge cases (L5B)#76
Nelson Spence (Fieldnote-Echo) wants to merge 2 commits intomainfrom
test/L5B-rule-fixture-batch

Conversation

@Fieldnote-Echo
Copy link
Member

Summary

  • Adds binary diff, renamed file, and deleted line edge-case tests to all 8 rule test files:
    • sinks (F-SNK-001), workflow (F-RW-001), traversal (F-TRV-001), llm-sinks (F-LLM-001)
    • ci-risk (F-CIR-001), sql (F-SQL-001), crypto (F-CRY-001), deserialization (F-DSR-001)
  • Aligns fixture matrices with the benchmark coverage established in secrets_in_diff
  • 24 new tests total (3 per rule × 8 rules)

Audit Context

  • Findings: F-SNK-001, F-RW-001, F-TRV-001, F-LLM-001, F-CIR-001, F-SQL-001, F-CRY-001, F-DSR-001 (all LOW)
  • Lane: L5B (Rule Fixture Batch) — Priority 5b in remediation plan

Test plan

  • uv run pytest tests/test_grippy_rule_*.py -v — 159 passed
  • uv run pytest tests/ -v — full suite passes (1180 passed)
  • Pre-commit hooks pass

🤖 Generated with Claude Code

…001)

F-SCH-002: parametrized required-field rejection tests for GrippyReview
KRC-01 graph-store: unicode data, special chars, empty type edge cases
KRC-01 graph-context: unindexed file, nonexistent author, shared dependent
F-PR-001: adversarial prompt content (injection, unicode, template syntax)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add binary diff, renamed file, and deleted line edge-case tests to all
8 rule test files that were missing them: sinks, workflow, traversal,
llm-sinks, ci-risk, sql, crypto, insecure-deserialization.

Aligns fixture matrices with the benchmark coverage in secrets_in_diff.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Collaborator

@project-navi-bot project-navi-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All required CI checks passed. Auto-approved by navi-bot.

Copy link
Collaborator

@project-navi-bot project-navi-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All required CI checks passed. Auto-approved by navi-bot.

@github-actions
Copy link
Contributor

✅ Grippy Review — PASS

Score: 100/100 | Findings: 0


Commit: a6dbbcd

Copy link
Collaborator

@project-navi-bot project-navi-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All required CI checks passed. Auto-approved by navi-bot.

Copy link
Collaborator

@project-navi-bot project-navi-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All required CI checks passed. Auto-approved by navi-bot.

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@project-navi-bot project-navi-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All required CI checks passed. Auto-approved by navi-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants