test: adversarial coverage for secrets + enrichment#73
Open
Nelson Spence (Fieldnote-Echo) wants to merge 1 commit intomainfrom
Open
test: adversarial coverage for secrets + enrichment#73Nelson Spence (Fieldnote-Echo) wants to merge 1 commit intomainfrom
Nelson Spence (Fieldnote-Echo) wants to merge 1 commit intomainfrom
Conversation
Add 5 adversarial tests for graph-derived enrichment suppression: - Substring collision: short import name vs file path - Path traversal import: ../../etc/passwd no crash - Empty import path: empty string handled safely - Crafted import name: documents substring match false-positive vector - Unicode import path: non-ASCII characters no crash F-RS-001 (ReDoS) already resolved by existing TestReDoS class (9 tests). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
project-navi-bot
approved these changes
Mar 15, 2026
Collaborator
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
project-navi-bot
approved these changes
Mar 15, 2026
Collaborator
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
Contributor
✅ Grippy Review — PASSScore: 100/100 | Findings: 0 Commit: c9e25b1 |
project-navi-bot
approved these changes
Mar 15, 2026
Collaborator
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
project-navi-bot
approved these changes
Mar 15, 2026
Collaborator
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
project-navi-bot
approved these changes
Mar 15, 2026
Collaborator
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_compute_suppression()import-based enrichment:"os"vs"cosmos/handler.py")"../../etc/passwd")Audit Context
Test plan
uv run pytest tests/test_grippy_rules_enrichment.py -v— all passuv run pytest tests/ -v— full suite passes🤖 Generated with Claude Code