fix: CLI fallback, grep path leak, WAL log level#72
fix: CLI fallback, grep path leak, WAL log level#72Nelson Spence (Fieldnote-Echo) wants to merge 1 commit intomainfrom
Conversation
…F-CB-001, F-GS-001) F-CLI-01: Print message before falling back to 'local' transport on invalid or out-of-range interactive input. F-CB-001: Strip absolute repo root prefix from grep output lines using line-anchored prefix removal — only the leading path segment is relativized, matched content is preserved unchanged. F-GS-001: Upgrade WAL mode and foreign key pragma failure log level from WARNING to ERROR to make silent degradation visible. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -111,8 +111,14 @@ def _install_mcp(argv: list[str]) -> None: | |||
| print(f" {i}) {t}") | |||
There was a problem hiding this comment.
🔵 LOW: Improved CLI feedback for invalid transport selection
Confidence: 92%
The PR adds explicit user feedback when a transport selection is out of range or cannot be parsed, before defaulting to 'local'. Previously, these silent fallbacks could cause confusion if a user supplied invalid input. The fix helps UX, but no logic bug existed in the fallback, only clarity.
Suggestion: No action needed, as this expands feedback for clarity. Optional: consolidate error messages if further simplification is desired.
— Not wrong, but there's a simpler way. This way's just fine.
| @@ -714,7 +714,15 @@ def grep_code(pattern: str, glob: str = "*.py", context_lines: int = 2) -> str: | |||
| return "No matches found." | |||
There was a problem hiding this comment.
🔵 LOW: Prevents absolute repo path leak in grep_code() output
Confidence: 93%
The grep_code() CLI tool previously outputted absolute repo-root paths, which could potentially leak internal path structure to LLMs or users. The fix strips the repo_root prefix for safety and privacy, producing relative paths in output.
Suggestion: No further action required. The fix is correct and scoped, but verify all output lines are covered-defense in depth.
— Works, but fragile-be sure to cover edge cases like symbolic links.
| @@ -111,14 +111,14 @@ def _init_schema(self) -> None: | |||
| actual = str(cur.fetchone()[0]) | |||
There was a problem hiding this comment.
🔵 LOW: Upgrades WAL/FK pragma error logs to ERROR level
Confidence: 95%
Previously, failures to set or validate SQLite PRAGMA statements were only logged at WARNING level, which could let critical persistence problems slip by. This change raises such issues to log.error, improving visibility-impact is increased reliability of diagnosing storage problems.
Suggestion: No further action needed; the log level change is appropriate.
— Observable code is debuggable code. Good move.
✅ Grippy Review — PASSScore: 94/100 | Findings: 3 Delta: 3 new Commit: c0602bb |
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
project-navi-bot
left a comment
project-navi-bot
left a comment
There was a problem hiding this comment.
All required CI checks passed. Auto-approved by navi-bot.
2 participants
Summary
grep_code()output (prevents path leak to LLM)Audit Context
Test plan
uv run pytest tests/ -v— full suite passesuv run ruff check src/grippy/ tests/— lint clean🤖 Generated with Claude Code